Issue on projection for fdajpca method

jdtuck / fdasrsf_python

elastic fda python code

http://research.tetonedge.net

BSD 3-Clause "New" or "Revised" License

52 stars 18 forks source link

Issue on projection for fdajpca method #42

Closed thibaut-germain closed 5 months ago

thibaut-germain commented 6 months ago

It seems that there is a mistake on project method of fdajpca class. There .new_coef are very localized compared to .coef. It seems like a scalar multiplication is missing.

jdtuck commented 5 months ago

I don't see a scaling error, please provide a minimum working example

jdtuck commented 5 months ago

Found small issue in the projection on the gradient calculation of psi in project fixed in latest commit