search

jdtuck / fdasrsf_python

elastic fda python code
http://research.tetonedge.net
BSD 3-Clause "New" or "Revised" License
52 stars 18 forks source link

Support for NumPy 2.0 #56

Closed vnmabus closed 2 months ago

vnmabus commented 3 months ago

NumPy 2.0 has been recently released, and modules compiled against previous versions are incompatible with it (but compiling against 2.0 apparently IS compatible with previous versions). When using NumPy 2.0 with code depending on this module I got the following message: "A module that was compiled using NumPy 1.x cannot be run in NumPy 2.0.0 as it may crash. To support both 1.x and 2.x versions of NumPy, modules must be compiled with NumPy 2.0. Some module may need to rebuild instead e.g. with 'pybind11>=2.12'.

If you are a user of the module, the easiest solution will be to downgrade to 'numpy<2' or try to upgrade the affected module. We expect that some modules will need time to support NumPy 2. "

Please, if you can compile against NumPy 2.0, that would be very helpful.

jdtuck commented 2 months ago

I cannot support this till oldest-supported-numpy is updated to support this for build as well as numba, cython, and cffi. This will have to wait

jdtuck commented 2 months ago

looks like a few are updated, let me test a few things today

jdtuck commented 2 months ago

oldest-supported-numpy is no longer needed per https://github.com/scipy/oldest-supported-numpy. Will work on this hopefully today.

jdtuck commented 2 months ago

fixed in main and release to pypi pending on CI