search

jdtuck / fdasrvf_R

Functional Data Analysis using Square-Root Slope Framework
10 stars 13 forks source link

Normalization error in srsf_to_f #2

Closed Almond-S closed 7 years ago

Almond-S commented 7 years ago

Hi,

thank you for that nice R package! However, I found a certain issue in the code of the function srsf_to_f:

The norm of the sqv-function in the multidimensional case is defined as qnorm = abs(q[, i]) , which must be qnorm = sqrt(crossprod(q[, i])).

Best, Almond

jdtuck commented 7 years ago

What do you mean by multidimensional, that is for functional data which is not multidimensional

jdtuck commented 7 years ago

For curves (multidimensional) you want q_to_curve

Almond-S commented 7 years ago

Oh yes, I see, I didn't expect that there's another function q_to_curve for the multidimensional case. Thank you!

jdtuck commented 7 years ago

No problem and thanks for asking questions :-)