Improving docs and unit tests (Part 1)

astamm commented 1 year ago

A first PR in which I improved docs and unit tests.

for joint fPCA and alignment;
for time_warping() and related boxplot capabilities.

In the process I refactored the boxplot code and removed some useless package dependencies as discussed in #21. Details are in the commit history. I also added myself as contributor if you do not mind.

I will continue improving documentation and unit tests but later on as I have no more time to dedicate to it this week.

If you are happy with these changes you can merge.

Thanks for the release on CRAN.

jdtuck commented 1 year ago

Please fix checks, also can you add my my ORCID like yours (0000-0001-8844-2169)

astamm commented 1 year ago

Yes I will add your ORCID. I am working on fixing the CI. Snapshot tests revealed a reproducibility issue between OSes in align_fPCA(). Some are just machine precision irrelevant issues that I am making disappear but I am investigating the rest.

astamm commented 1 year ago

Done. This PR can be merged. ORCID added too.

jdtuck / fdasrvf_R

Improving docs and unit tests (Part 1) #23