Closed astamm closed 8 months ago
See code review above
Thanks but I do not see the review.
where did the centering go? This is a large PR so have had hard time going through the diff to find it if you moved it.
I have it done under curve_to_srvf()
in curve_functions.R
.
Is this ready to merge?
closes #44 and #42
Well it does pass current tests and should not break current user experience and should make one or two things faster.
In one of my commits, I added Closes #42 but I wouldn't close #44 as I have not yet done this.
find_rotation_seed_unique()
andfind_rotation_seed_coord()
; penalty option is added for both;calc_shape_dist()
andcurve_dist()
using newly defined internal functionscurve_to_srvf()
andmatch_f2_to_f1()
;utils-pointwise.R
:amplitude_distance()
computes the distance in amplitude between two SRVFs supposed optimally transformed;phase_distance()
computes the distance in phase between two SRVFs assumed to be already optimally transformed using the estimated $\gamma$;pointwise_mean()
computes or updates the Karcher mean or median using a set of SRVFs assumed to be already optimally transformed.These internal functions should be helpful in making the code for Karcher mean computation clearer in the near future.
kmeans_align()
which was broken; still needs an update though; in a near future as well.