jdtuck / fdasrvf_R

Functional Data Analysis using Square-Root Slope Framework
11 stars 15 forks source link

Improved distance (matrix) computation #45

Closed astamm closed 8 months ago

astamm commented 8 months ago

These internal functions should be helpful in making the code for Karcher mean computation clearer in the near future.

jdtuck commented 8 months ago

See code review above

astamm commented 8 months ago

Thanks but I do not see the review.

jdtuck commented 8 months ago

where did the centering go? This is a large PR so have had hard time going through the diff to find it if you moved it.

astamm commented 8 months ago

I have it done under curve_to_srvf() in curve_functions.R.

jdtuck commented 8 months ago

Is this ready to merge?

jdtuck commented 8 months ago

closes #44 and #42

astamm commented 8 months ago

Well it does pass current tests and should not break current user experience and should make one or two things faster.

astamm commented 8 months ago

In one of my commits, I added Closes #42 but I wouldn't close #44 as I have not yet done this.