Enable cross-building for Scala.js 0.6 and 1.0

jducoeur / jsext

Commonly-useful extensions for Scala.js, particularly for facade development

28 stars 12 forks source link

Closed frne closed 4 years ago

frne commented 4 years ago

Could you please publish a Scala.js 0.6 and 1.0 version for Scala 2.12 and 2.13 accordingly?

Hope this is helpful to do it...

frne commented 4 years ago

Relates to #18

mathieuleclaire commented 4 years ago

Hi, I suggest to set

val scalaJSVersion = Option(System.getenv("SCALAJS_VERSION")).getOrElse("1.0.1")

instead of

val scalaJSVersion = Option(System.getenv("SCALAJS_VERSION")).getOrElse("0.6.32")

frne commented 4 years ago

@mathieuleclaire Already done, see second commit ;)

mathieuleclaire commented 4 years ago

You're right, sorry. It sounds good to me then. Thanks @frne