search

jdunck / python-unicodecsv

Python2's stdlib csv module is nice, but it doesn't support unicode. This module is a drop-in replacement which *does*. If you prefer python 3's semantics but need support in py2, you probably want https://github.com/ryanhiebert/backports.csv
Other
594 stars 87 forks source link

Unbreak Python 2.6 after version 0.13.0? #62

Closed xZise closed 9 years ago

xZise commented 9 years ago

pywikibot-core is currently using unicodecsv on Python 2.7 and 2.6 and removing support for Python 2.6 broke support. Now it's not that much of a problem as users could install an older version. But I wanted to ask whether you are interested in supporting 2.6 again by using OrderedDict from a third party library like ordereddict or future. If you want I could work on a pull request, but there still seem to be a lot of Python 2.6 users especially those using Redhat Linux.

Now if you are not interested you can just close this bug and we're going to limit the version to 0.13.0 on Python 2.6.

ryanhiebert commented 9 years ago

2.6 is supported again, via reverting that change that required OrderedDict.

jdunck commented 9 years ago

@xZise is it reasonable to upgrade to 0.14.1?

xZise commented 9 years ago

I hope you didn't revert because of us ;) Anyway if only 0.14.0 does not support Python 2.6 we can forbid only 0.14.0 on it so that new users will install the most recent version. I've done that in xZise/pywikibot-core@fe12b566d0d2411d428c9637d16a85c0283ac906 and currently let it run our tests on https://travis-ci.org/xZise/pywikibot-core/builds/81838549

It's not merged into the repository yet as I'm waiting for the results of these tests. Not sure what you mean with upgrade to 0.14.1 (if you mean something else) as we can't bring the users to install a the most recent version unless they install it with my new definition of course.

ryanhiebert commented 9 years ago

@xZise: Since 0.14.0 breaks your software, you'll need to note that it isn't compatible. It sounds like that's you're method. Are you satisfied to close this issue, then?

xZise commented 9 years ago

Okay 0.14.1 is now installed so it should be fine. Users who have 0.14.0 installed on Python 2.6 will get an error when they try to insta Pywikibot. I think that enough (apart from the fact that the user installed an invalid version beforehand).