search

jdx / mise

dev tools, env vars, task runner
https://mise.jdx.dev
MIT License
10.32k stars 295 forks source link

Checksum for Java Sapmachine 17.0.12 (Linux x64) is wrong #2567

Closed marcellippmann closed 2 months ago

marcellippmann commented 2 months ago

Describe the bug The checksum of java@sapmachine-17.0.12 is wrong for Linux x64.

To Reproduce

$ mise install java@sapmachine-17.0.12
mise Checksum mismatch for file ~/.local/share/mise/downloads/java/sapmachine-17.0.12/sapmachine-jdk-17.0.12_linux-x64_bin.tar.gz:
Expected: db1d458be8e5c4fb9dad6b2641f6fec27b85aa93bea8801d868b90099da45ce6
Actual:   53c035d9d496f6a29a2beb19181d69597796c0903385207f76c3d63671681673
mise Run with --verbose or MISE_VERBOSE=1 for more information

Expected behavior The java distribution can be installed and the the “expected checksum” matches with the one provided by the vendor; see https://github.com/SAP/SapMachine/releases/download/sapmachine-17.0.12/sapmachine-jdk-17.0.12_linux-x64_bin.sha256.txt

mise doctor output

version: 2024.9.2 linux-x64 (283d988 2024-09-11)                                                                                                                                                                                                                                                                                                                                                                                         
activated: yes                                                                                                                                                                                                                                                                                                                                                                                                                           
shims_on_path: no                                                                                                                                                                                                                                                                                                                                                                                                                        

build_info:                                                                                                                                                                                                                                                                                                                                                                                                                              
  Target: x86_64-unknown-linux-gnu                                                                                                                                                                                                                                                                                                                                                                                                       
  Features: DEFAULT, NATIVE_TLS, OPENSSL                                                                                                                                                                                                                                                                                                                                                                                                 
  Built: Wed, 11 Sep 2024 23:20:11 +0000                                                                                                                                                                                                                                                                                                                                                                                                 
  Rust Version: rustc 1.81.0 (eeb90cda1 2024-09-04)                                                                                                                                                                                                                                                                                                                                                                                      
  Profile: release

Additional context None.

roele commented 2 months ago

@jdx How does https://rtx-java-metadata.jdx.dev/metadata/{}/{}/{}.json work exactly?

I let the Update Metadata job recreate the files for sapmachine-[jdk|jre]-17.0.12 versions in https://github.com/jdx/rtx-java-metadata (respectively in my fork and merged them over) and the checksums should be okay now in the source files.

jdx commented 2 months ago

it's fronted by cloudflare so there may have been some caching going on, it looks good now. In the future, you can use curl --verbose to see the headers which I think will display the cache information

roele commented 2 months ago

@marcellippmann This issues should be resolved by now.

marcellippmann commented 2 months ago

Yes, it's resolved. Thanks a lot for the quick fix!