search

jeFF0Falltrades / rat_king_parser

A robust, multiprocessing-capable, multi-family RAT config parser/config extractor for AsyncRAT, DcRAT, VenomRAT, QuasarRAT, XWorm, Xeno RAT, and cloned/derivative RAT families.
MIT License
32 stars 4 forks source link

maco as extra dependencies for most of us #10

Closed doomedraven closed 3 weeks ago

doomedraven commented 3 weeks ago

hello, could we put maco as side dependencies to reduce number of extra dependencies for those who doesn't need it?

it just become to be installed with rkp["maco"]

jeFF0Falltrades commented 3 weeks ago

@doomedraven This is a phenomenal idea - I was going to try to research a way to separate out the external parsing utilities before updating RKP to v3.1.0, but this method keeps things pretty simple for now by keeping the code in the main repo, while not requiring users to download the optional deps.

One thing I did change in your branch is to define the optional dependencies in PEP instead of poetry as I'm not (yet) using poetry on this project.

@cccs-rs : Are you able to accommodate this change downstream in your tooling to parse the dependencies for RAT King Parser's MACO portion as optional dependencies? I.e. if using pip, the pip command now becomes pip install "git+https://github.com/jeFF0Falltrades/rat_king_parser.git#egg=rat_king_parser[maco]"

cccs-rs commented 3 weeks ago

@jeFF0Falltrades PR staged to update the tool to handle optional-dependencies so we'll be able to still use the MACO portion of RAT King Parser in Assemblyline🤓

jeFF0Falltrades commented 3 weeks ago

You guys are both just stellar to work with 😄

I'm going to merge this PR, and I will update the Release a little later once I get the README updated.

Thanks, gents!