Closed akhilles closed 4 years ago
I think that's its fine if the Debug
implementation of Error
does not output the content
. So you could add a separate manual implementation such as:
impl fmt::Debug for Error {
fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {
fmt.debug_struct("Error")
.field("kind", &self.kind)
.finish()
}
}
This would allow the T: Debug
bound to be removed everywhere.
Looks good. Can I merge?
Looks good. Can I merge?
Yup!
Good stuff! I'll do a release.
failure
seems to be deprecated and there are some compelling reasons to usethiserror
instead:thiserror
doesn't introduce any custom traitsstd::error::Error
which means compatibility isn't broken if it's replaced down the roadanyhow
I would have opened an issue to discuss this, but I was already using the forked version so decided to just submit a PR.