Cleanup previous merge - Githubissues

jean-airoldie / zeromq-src-rs

Source code and logic to build ZeroMQ from source

MIT License

11 stars 14 forks source link

Cleanup previous merge #18

Closed jean-airoldie closed 2 years ago

jean-airoldie commented 2 years ago

Make linking against libsodium mandatory to enable curve.
Remove unused structures.
Update tests to reflect changes.

@Jasper-Bekkers

I'm thinking of merging this then release 0.2. Then I'll PR libzmq.

Btw thanks a lot for your work, I know for a fact that making c & c++ builds work properly is nightmarish.

jean-airoldie commented 2 years ago

@Jasper-Bekkers Can you tell me if this PR work properly for you? I'll merge then release if so.

Jasper-Bekkers commented 2 years ago

It looks like it's quite an ordeal on our end to just patch this PR in because of the version bump, however, I have managed to do so and thing seem to work correctly on our end.

jean-airoldie commented 2 years ago

Alright I'll merge and submit a PR to zmq.