search

jean-airoldie / zeromq-src-rs

Source code and logic to build ZeroMQ from source
MIT License
11 stars 14 forks source link

Create git tags for releases #35

Closed MarijnS95 closed 10 months ago

MarijnS95 commented 10 months ago

From the log it is a tad hard to follow what commits have been included in a certain release.

It is probably not worth tagging older releases, but in any case the git hash can be reconstructed from the .cargo_vcs_info.json file in the source package, i.e.: https://docs.rs/crate/zeromq-src/0.2.6+4.3.4/source/.cargo_vcs_info.json

jean-airoldie commented 10 months ago

Yeah, I don't mind adding git tags. At least the release version contains the specific libzmq version.

jean-airoldie commented 10 months ago

Added tag for latest release. If you need a specific older tag, just tell me.

MarijnS95 commented 10 months ago

Cool! Having tags for at least the latest 2-3 releases (0.2.3-0.2.6) might be nice too, as folks are still using those.

MarijnS95 commented 10 months ago

https://crates.io/crates/zeromq-src even "other" releases are still used.

jean-airoldie commented 10 months ago

Added tags for 0.2.4 to 0.2.6, which i validated against the crates.io hash. I skipped 0.2.3 because the version is yanked, due to a problem with cloning submodules, if i recall correctly.

MarijnS95 commented 10 months ago

@jean-airoldie thanks! I don't think it would hurt having tags for yanked releases though, this still makes it clear at what point in the tree such a "broken and yanked" release was created.