jean-emmanuel / open-stage-control

Libre and modular OSC / MIDI controller
https://openstagecontrol.ammd.net
GNU General Public License v3.0
702 stars 88 forks source link

Check in drop down menus are not updated #604

Closed Normandeau closed 4 years ago

Normandeau commented 4 years ago

Please provide as much contextual informations as possible:

We are using Open Stage Control to send OSC data to a plugin called ControlGRIS. It works pretty well in both directions, which means that OSC data is sent to ControlGRIS and vice versa. Except for one little thing. We have two drop down menus in ControlGRIS: Source Link and Source Link Alt. When one of the options is chosen, it's updated in both ways, except that in Open Stage Control, there is a check (√) beside the chosen menu which doesn't exist in ControlGRIS. If the option is changed in ControlGRIS, the option is changed accordingly in the iPad, but the check stays to the previous option.

See the joint image: Open Stage Control Check

ControlGRIS is available here: https://github.com/GRIS-UdeM/ControlGris/releases

ControlGrisOSC.json is here: https://github.com/GRIS-UdeM/ControlGris/blob/master/ControlGrisOSC.json

jean-emmanuel commented 4 years ago

Thanks for the detailed report.

Is the dropdown menu already opened on the iPad when the value changes ? This widget relies on the system's dropdown implementation is somewhat limitated: the check mark is only updated when the menu opens. The only fix I found is to simply close the dropdown when it receives a value while opened.

Normandeau commented 4 years ago

No, the drop down menu is not open in the iPad. But there is no difference in the behaviour, whether the drop-down menu is opened or not. The option with a check mark is never the good one if it was changed from the ControlGRIS. But as the option that shows is the real active one, it's not really an issue. It's mostly cosmetic. We have had also a check mark in ControlGRIS that we just removed because essentially it is a pleonasm.

jean-emmanuel commented 4 years ago

Ok, last question: when OSC receives a value, does the check mark never update or does it always update to the value under the correct one ?

Normandeau commented 4 years ago

The check mark stays at the option chosen on the iPad. In this case, let's say I chose Circular on the iPad. After that, whatever the option I chose In ControlGRIS (Independent. Fixed Radius, etc.), Circular remains checked.

Normandeau commented 4 years ago

Also, a question: why there is an empty slot in the drop-down menu: Capture d’écran, le 2020-03-23 à 11 23 19

have we made a mistake here: { "Independent": 1, "Circular": 2, "Circular Fixed Radius": 3, "Circular Fixed Angle": 4, "Circular Fully Fixed": 5, "Delta Lock": 6, "Symmetric X": 7, "Symmetric Y": 8 }

Normandeau commented 4 years ago

Go to Github to see the second part of the message. My post was sent too early!

jean-emmanuel commented 4 years ago

It may be a bug in this particular version of iOS, the one I could test did not behave that way. Do you know which iOS/iPad version you're using ?

Also, a question: why there is an empty slot in the drop-down menu:

It is indeed a questionable design choice I made long ago and that I'm getting rid of in v1.

Normandeau commented 4 years ago

iPadPro iOS 13.3.1

jean-emmanuel commented 4 years ago

I confirm, the bug only occurs on iOS 13, it should be fixed in v0.49.12 (last v0 release).

Normandeau commented 4 years ago

v0.49.12 Solved

jean-emmanuel commented 4 years ago

Great !