jean-emmanuel / open-stage-control

Libre and modular OSC / MIDI controller
https://openstagecontrol.ammd.net
GNU General Public License v3.0
720 stars 91 forks source link

[Bug] widgets with same address but different targets update each other #605

Closed jgastonraoul closed 4 years ago

jgastonraoul commented 4 years ago

In release 0.49.11, I've a problem with widgets using the same address on different targets that update each other... Is it a normal feature ? If yes, how to avoid that ?

Regards,

Jérémie

jean-emmanuel commented 4 years ago

Do the widgets have the same id or linkId ? If so, you need to change one of them to avoid that. Widget sync within a session does not rely on osc properties, unlike cross-client sync.

jgastonraoul commented 4 years ago

I can confirm that the widgets have no linkId, different ids and different targets, but they are synchronized as long as they have the same OSC address...

jean-emmanuel commented 4 years ago

Can you post a minimal session to help me reproduce the issue ?

jgastonraoul commented 4 years ago

Here is an exemple...

2020-03-23_13_34.json.zip

jean-emmanuel commented 4 years ago

Loading your example with all server options to default does not produce the error (the widgets don't update each other).

jgastonraoul commented 4 years ago

I think I've located the problem... And I have a question : if I set a default "send" option in O-S-C startup interface and a different "target" in the widgets, does it send to the default send AND specific target or does the "target" override the default "send" ?

jean-emmanuel commented 4 years ago

It sends to both unless the widgets has a null target: ["localhost:5555", null] would bypass the server's target. https://openstagecontrol.ammd.net/docs/widgets-reference/#osc

jgastonraoul commented 4 years ago

Ok, thank you ! I was thinking that "target" was overriding "send".

Regards,

Jérémie