jean-emmanuel / open-stage-control

Libre and modular OSC / MIDI controller
https://openstagecontrol.ammd.net
GNU General Public License v3.0
701 stars 88 forks source link

[possible bug] when saving Session #672

Closed schoko11 closed 3 years ago

schoko11 commented 3 years ago

OpenStageControl4reaper_13.json.zip

when loading this i got a console error because of an undefined or null object (line 3, kempStompAFXSel, label property) when try to fix that i hit save and then when closing the session i got a warning because of unsafed changes (the popup says successfully saved). Apart from that i can't alter the JS in the property(sometimes it works after several tries.. ?), hitting "no" on the warning always closes the client session(not what i expect)...

Thanks!

jean-emmanuel commented 3 years ago

when loading this i got a console error because of an undefined or null object (line 3, kempStompAFXSel, label property)

That not a bug but an error occurring when the code is executed before the @{} blocks have a value, the only way to avoid it is to provide a fallback value (eg var x = @{widget_id} || {})

when try to fix that i hit save and then when closing the session i got a warning because of unsafed changes (the popup says successfully saved). Apart from that i can't alter the JS in the property(sometimes it works after several tries.. ?), hitting "no" on the warning always closes the client session(not what i expect)...

I'll need more details on how to reproduce this error.

schoko11 commented 3 years ago

Thanks, will try to fix that.

I just can describe you what i did. open the session enable the editor go to tab kemper go to widget "kempStompAFXSel edit label property hit save when stopping the server the alert of unsaved changes come up.

jean-emmanuel commented 3 years ago

what version of o-s-c are you using ?

Le 02/12/2020 à 16:36, schoko11 a écrit :

Thanks, will try to fix that.

I just can describe you what i did. open the session enable the editor go to tab kemper go to widget "kempStompAFXSel edit label property hit save when stopping the server the alert of unsafed changes come up.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jean-emmanuel/open-stage-control/issues/672#issuecomment-737308585, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIESZ37DKVKDYGE56OKCR3SSZNIRANCNFSM4UKTK4YQ.

schoko11 commented 3 years ago

1.7.3

jean-emmanuel commented 3 years ago

I just followed these steps with 1.7.3 (built-in client) and did not encountered any error or strange behavior.

Le 02/12/2020 à 16:48, schoko11 a écrit :

1.7.3

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jean-emmanuel/open-stage-control/issues/672#issuecomment-737315783, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIESZYX5SSQ7NJN6IAOCYDSSZOTNANCNFSM4UKTK4YQ.

schoko11 commented 3 years ago

That is a little bit weird, because i can't save the session, i opened up the json file and copied in the JS code. (there were no " in it, so had not to escape this with a backslash ). After saving the json file, i couldn't open it(json parse error). Then i deleted some blanks(i thought i could spot the position) and added \n linebreaks. Notepad++ is at (Unix LF utf-8 computer is WIN10), maybe i copied in some "illegal char" that breaks it...

jean-emmanuel commented 3 years ago

Maybe https://jsonchecker.com/ could help

jean-emmanuel commented 3 years ago

Closing for now. Feel free to reopen if more informations come up.