jean-emmanuel / open-stage-control

Libre and modular OSC / MIDI controller
https://openstagecontrol.ammd.net
GNU General Public License v3.0
702 stars 88 forks source link

[Bug] Fragments session does not load correctly, need to preload each fragment #767

Closed groolot closed 2 years ago

groolot commented 2 years ago

Problem

When I try to load a global session with encapsulated fragments (nested) client enters in a kind of endless loop which is unfortunately not debugable within JavaScript console. But, if I preload each fragment before it is loaded by an encapsulator, everything is fine and the UI is fluid as beer in a dry throat.

groolot commented 2 years ago

https://user-images.githubusercontent.com/632571/149843384-53636b07-7383-4879-a604-a78b6d2e3562.mp4

jean-emmanuel commented 2 years ago

Found and fixed with f419ac8b, a nasty bug indeed !

groolot commented 2 years ago

Still have the same behaviour :(

jean-emmanuel commented 2 years ago

If you run a packaged v1.14.0 before pulling the latest commits you may encounter a caching issue, please pull and run npm run build again, I bumped the version number (it is used to determine the cache validity).

groolot commented 2 years ago

ok, the latest 291eb669 fixes the bug! great job!