jean-humann / docs-to-pdf

Generate PDF for document website 🧑‍🔧
https://www.npmjs.com/package/docs-to-pdf
MIT License
87 stars 14 forks source link

docs: specify details elements not found in debug message #360

Open giraffesyo opened 7 months ago

giraffesyo commented 7 months ago

Currently running the command prints "Found 0 Elements" on all pages that don't have a details element. This initially misled me to believe the tool wasn't working. This PR simply makes that logging a little more specific.

Original

[21.12.2023 13:57.48.821] [LOG] Retrieving html from https://parallelworks.com/docs/ [21.12.2023 13:57.49.823] [DEBUG] Found 0 elements [21.12.2023 13:57.49.824] [LOG] Success

New

[21.12.2023 14:07.51.459] [LOG] Retrieving html from https://parallelworks.com/docs/ [21.12.2023 14:07.53.476] [DEBUG] Found 0 elements of type details [21.12.2023 14:07.53.478] [LOG] Success

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e602d41) 95.32% compared to head (2e53897) 95.32%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #360 +/- ## ======================================= Coverage 95.32% 95.32% ======================================= Files 4 4 Lines 792 792 Branches 35 35 ======================================= Hits 755 755 Misses 37 37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jean-humann commented 7 months ago

LGTM @giraffesyo thanks for your contribution !

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud