search

jean-humann / docs-to-pdf

Generate PDF for document website 🧑‍🔧
https://www.npmjs.com/package/docs-to-pdf
MIT License
104 stars 18 forks source link

fix: fixed crash if details inside of tabs #428

Open anatolykopyl opened 7 months ago

anatolykopyl commented 7 months ago

Fixes https://github.com/jean-humann/docs-to-pdf/issues/364

If Details was in a non default TabItem, then it was not accessible by puppeteer. Changed the .click() to a click inside of an .evaluate().

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.32%. Comparing base (0e27e41) to head (e05a883).

Files Patch % Lines
src/utils.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #428 +/- ## ======================================= Coverage 95.32% 95.32% ======================================= Files 4 4 Lines 792 792 Branches 35 35 ======================================= Hits 755 755 Misses 37 37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Mimameid commented 3 months ago

Change fixes it for me too. Saw the same suggestion here.