jean-moreno / EdgeDetect-PostProcessingUnity

Unity legacy Edge Detect image effect ported to Post Processing Stack v2
298 stars 32 forks source link

Destroys Post Processing in Standalone Build #2

Closed ghost closed 6 years ago

ghost commented 7 years ago

Hello,

So I just updated Post Processing v2, and found that this script is killing the Post Processing Stack on a standalone build. The effects work perfectly fine in the Editor. It does not matter where in the stack it is, the problem still exists. It also doesn't matter is nothing at all is selected, as long as the effect is either set to "on" or checked enabled it will break the entire stack.

Edit: One more thing to note: It can be the only effect in the stack and it breaks the post processing.

Daahrien commented 7 years ago

I have the same problem

Daahrien commented 6 years ago

@dog199200 were you able to find a workaround?

ghost commented 6 years ago

No, I was not. I just ended up removing it entirely until something can get fixed...

Daahrien commented 6 years ago

well, I used the legacy edge detection script directly instead of using this add on.

jean-moreno commented 6 years ago

@Lestat @dog199200 Can you try to add the EdgeDetectNormalsPostProcess.shader file to the "Always Included Shaders" in Edit > Project Settings > Graphics? This seem to have worked for me. I'll see if there's a way to prevent doing that for the effect to work properly though.

Daahrien commented 6 years ago

Will test, although maybe im better using the legacy edge detection script directly, I think is less risky than rely on this addon :p

Daahrien commented 6 years ago

Well, it works now :p

ghost commented 6 years ago

I am still unable to get it to work.

inspector1 inspector2 inspector3

Daventor commented 6 years ago

I must add:

pragma glsl

to avoid an error whem make the build, but now this works fine.

jean-moreno commented 6 years ago

@dog199200 please try the latest version, I moved the shader to the Resource folder. If it still doesn't work, please let me know which version of Unity you are using and the target platform.

@Daventor that sounds weird, #pragma glsl should have no effect anymore since Unity 5! (see: https://docs.unity3d.com/Manual/SL-ShaderPrograms.html)