jean997 / cause

R package for CAUSE
https://jean997.github.io/cause/
52 stars 15 forks source link

unused argument with "gwas_merge" #19

Closed wzxiao1217 closed 3 years ago

wzxiao1217 commented 3 years ago

Hi Jean,

I notice the latest example for gwas_merge add the argument "pval_cols", but when I apply the argument, then comes the error: unused argument...I am not sure whether the argument has been updated in the latest release version 1.2.0, or what I can do to fix the problem.

Many Thanks, Zixiao

jean997 commented 3 years ago

Hi Zixiao -- I just added the pval_cols argument in the latest version. You can install with devtools::install_github("jean997/cause"). There should be a note about that in the tutorial -- I will add it. Thanks! Jean

wzxiao1217 commented 3 years ago

Thanks, Jean. That's very helpful!

Urban90 commented 1 year ago

Although I have installed it through devtools::install_github("jean997/cause") I still get the same issue. Is there anything else I could do to fix the problem? Thank you.

jean997 commented 1 year ago

can you check the version you have installed?

Urban90 commented 1 year ago

With packageVersion("cause") my output is 1.2.0

jean997 commented 1 year ago

The pval_cols option was added in version 1.2.030 so you need to update to the latest version by re-installing with the install_github command. (see Release Notes here: https://github.com/jean997/cause)

Urban90 commented 1 year ago

Thank you for your reply! However, I had used both devtools::install_github("jean997/cause") and devtools::install_github("jean997/cause") and devtools::install_github("jean997/cause@v1.2.0") and I still get the same error. Should I do something different? Thank you.

jean997 commented 1 year ago

If you use devtools::install_github("jean997/cause") you will get the latest version. I haven't made a new release since that option was added so you have to use the latest version and not the release version. If you check sessionInfo() you should see that the version number for cause is 1.2.0.0335

Urban90 commented 1 year ago

Thank you! After I reinstalled "R" and "cause" it worked.