jeanbaptisteb / classic_wikipedia

A Firefox extension to get the classic Wikipedia interface back, pre-January 2023.
https://jeanbaptisteb.github.io/classic_wikipedia/
4 stars 0 forks source link

Ignore api.php requests #3

Closed Seb35 closed 6 months ago

Seb35 commented 8 months ago

It’s a detail, but it would be great to ignore the requests /w/api.php on all wikis. The parameter useskin=vector is not recognised by the API and MediaWiki emits a warning (example).

PS: thanks a lot for this extension!

jeanbaptisteb commented 8 months ago

@Seb35 Thanks for the feedback, I'll have a look at it soon. I'm super busy these days but unless I missed something, it shouldn't be complicated at all to fix. I'm confident I'll have it fixed in a couple of weeks.

If by any chance you know of other exceptions like this, please let me know, I'll fix them at the same time. By the way, if you speak French, we can discuss in this language if you prefer.

Just as a reminder for myself (or if someone else wants to test it before I deploy the fix), in the background.js file, adding the string /w\/api.php/ in the var excludedUrls array should fix the issue very simply, such as:

var excludedUrls = [/(www|nostalgia|[.]m)[.]wikipedia[.]org/, /www[.]wiktionary[.]org/, 
/(.*[.]m[.]|m[.])/, 
/.*[.]m[.]wikimedia[.]org/,
/commons[.]m[.]wikimedia[.]org/,
/mobileaction=toggle_view_mobile/,
/w\/api.php/
]
jeanbaptisteb commented 6 months ago

@Seb35 The bug is (hopefully) corrected. I submitted the new version of the module on the Firefox developer hub, and the update should be effective in 24 hours. It was a bit more complicated than what I thought. Tell me if it works as expected, or if it still requires some modifications.

jeanbaptisteb commented 6 months ago

@Seb35 It seems that the new version is already available on the Firefox addins catalog, you don't even have to wait 24 hours if you want to try and update it.

jeanbaptisteb commented 6 months ago

@Seb35 Without negative feedback after two weeks of deployment, I consider the issue as solved, but if you encounter some problems again, feel free to reopen the discussion.

Seb35 commented 6 months ago

Ah, I missed the previous notifications, sorry. And indeed the version 1.5.2 works well, thanks a lot!