jeancarl / node-red-contrib-tjbot

Node-RED nodes that can be used with the TJBot running on a Raspberry Pi.
6 stars 20 forks source link

I think I found a bug in the TJBot speak node language selection #4

Open hugues-michel opened 6 years ago

hugues-michel commented 6 years ago

Thanks for this Node-Red TJBot contrib ! To introduce my grandson to new technologies with TJBot I followed your video "Train TJBot to Speak Headlines in Node-RED", in US-english work perfectly.

While trying with a french RSS feed, I think I found a bug. Explanations:

I correctly set up "tjbot-config node" and added several "debug nodes" to check. With the french RSS feed input the "speak node" speaks with the default voice "en-US_MichaelVoice" when reading from French ! With a string "inject node" filled with "Ceci est un test en langue française", I listen to the beautiful voice of renee speaking French.

I found two solutions to get around the problem 1st : use the translate node Between "feed parse node" with French reading and "speak node", I insert "translate node" with a conversion from French to English. It works well, I hear the renee voice. I tried to find the bug by looking at all the fields (debug complete msg object), but I didn't succeed. But that's what allowed me to find the second solution

2nd by editing this file: nano ~/.node-red/nodes/node-red-contrib-tjbot/node_modules/tjbot/libls/tjbot.js

// default voice var voice = "fr-FR_ReneeVoice"; // var voice = "en-US_MichaelVoice";

So, you probably have other things to do than watch this. But given the great work you've done, I couldn't remain silent.