jeancochrane / mellow-bike-map

🚲 Web app and routing API for finding safe, chill bike routes. Like Google Maps if it took you through cozy side streets.
https://mellowbikemap.com
MIT License
13 stars 5 forks source link

Let users save locations and factor js into a few modules #41

Closed kalilsn closed 2 years ago

kalilsn commented 2 years ago

Opening a draft for some feedback now, but I'll update this again when I finish making the changes that Jean has already asked for:

I'll also add a new style for the location marker and lightly clean up the styles on the new popup elements I've added.

Aside from UI questions, I'm also interested in feedback on the overall structure here. For example, there's definitely more stuff that could be broken out into its own module to shrink app.js, let me know if there's something there I should do. Should the modules be more functional instead of classes? Should the modules be organized differently? Should we implement this like a redux app with state + reducers?

Closes #35

kalilsn commented 2 years ago

I made two of the changes you asked (darker location marker and hearts for saved locations) and I'll open issues for the rest, then merge this.

I appreciate your thoughts about organization: I also don't know what will work best and I'm just trying things out! Grouping by feature seems reasonable so that's what I'll stick with for now.