search

jeancroy / FuzzySearch

:mag: Fast autocomplete suggestion engine using approximate string matching
MIT License
194 stars 32 forks source link

Updating minimalistic example readme #4

Closed gustavo-momente closed 7 years ago

jeancroy commented 7 years ago

Hi can you explain why you made the changes? Was it not working? I think a lot of library use the convention of not using the key option when handling simple string.

If it was broken I migth fix that instead

gustavo-momente commented 7 years ago

Hi, sorry for the pr with no comments, I was in a hurry. Basically, I found you lib awesome and wanted to use it in a project. I was trying to use the minimalistic example, but couldn't get it to work. So after some testing I found that when using a list as source I have to pass keys with [] or '' to make it work, that's contrary to what was in the documentation. So I thought that maybe the documentation was lagging behind some changes and tried to update it.

jeancroy commented 7 years ago

Thanks for the contribution. I think I fixed the root cause that caused the documentation to be wrong. I'll close this for now, I you still have problem I can reopen.