search

jeancsanchez / Simple-MVP-Retrofit-example

A simple example of a project using MVP architecture and Retrofit 2.0 library for Android for beginners.
69 stars 38 forks source link

CountryPresenter must not fetch data #1

Open sharukhmohammed opened 5 years ago

sharukhmohammed commented 5 years ago

CountryPresenter is currently responsible for fetching the data, which actually must be done by CountryModel. This violates the separation of concerns

jeancsanchez commented 5 years ago

@sharukhmohammed I agree with you, however, it is not the case here. If you are taking into account the principles that follow DDD and/or Clean Architecture, this can be the truth. But this project is a simple example of how to start with MVP. The main idea of this repository is to show for beginners how to start using MVP and they should improve this code on their own projects.