jeandeaual / tts-deckconverter

Generate card decks for Tabletop Simulator.
MIT License
38 stars 5 forks source link

Cardfight Vanguard Plugin Improvement Ideas #22

Open SleepyGuard opened 3 years ago

SleepyGuard commented 3 years ago

Hello! Before I jump in, I just wanted to say your Deckconverter program is fantastic! It's exactly what I was looking for in order to make deckbuilding for VG TTS easier. That said, I noticed a few things that might make it even more useful:

  1. Being Able to Pull Sets/Clans/Etc from the Cardfight Wiki: The ability to pull directly from the Cardfight Wiki is extremely useful, but the program requires a "Card List" heading on the entered page, as well as an "Amount" of cards, which severely limits this feature. Many pages on the wiki simply do not have those sections, or have different wordings. As an example, the clan page for Dimension Police ( https://cardfight.fandom.com/wiki/Dimension_Police_(V_Series) ) has "List of Dimension Police Cards" instead of "Card List", so it doesn't work. Most card sets aside from Trial Decks also do not list an Amount. If you could make it so the program had the ability to pull sections without that specific header, as well as maybe set the card count default to 1 if it isn't listed, then it would allow people to grab all cards for a Set/Clan/Nation/Etc, instead of having to find a specific deck list. It would be extremely useful!

  2. Small Bug - New Overdress Cards Not Showing Nation: I don't know if you follow it, but Vanguard recently announced another major Reboot, called "Overdress", with new mechanics, etc. One major change; no more Clans in the new stuff, and all new Nations. I pulled a Trial Deck off the Cardfight Wiki with the program, but on the generated cards, the new Nations are not showing on the card information.

  3. Personal Request - Ability to Generate Cards Without Text Fields Bolded: This is more a personal request. I've been working on a VG TTS Mod, and when I need to do regex stuff in LUA referencing generated card information, such as Power/Shield/Etc, the generated tags making the text bold keep tripping me up. If there's an easy way to implement it, I would really appreciate an option to turn that off for generated cards.

jeandeaual commented 3 years ago

@SleepyGuard Hi! Sorry, I just noticed your PR. Your suggestions make a lot of sense. I'll try to take a look sometime during the week-end.

  1. and 3. shouldn't take much time to implement. 1. will take more time, but it should be possible. Thanks for the suggestions!
SleepyGuard commented 3 years ago

No worries, glad to get a reply! I actually ended up trying my hand at scripting something for number 1, and ended up with a workable Python program for it. (I don't know enough Go to try in Go.) It's very rough around the edges though, compared to your program, and I'm still fiddling with it. If you hit any snags, maybe send me a message, I might have hit the same issue(s). One thing I ended up doing, after a LOT of trial and error, was formatting the script so that it would generate the cards already in a Bag, based on the Clan/Grade/Etc. Like, if I were scraping Dimension Police, it would scrape the card info, and generate like "Bag of Grade 0", "Bag of Crit", "Bag of Grade 1". etc etc. Made finding cards in the game much easier.