search

jeandeaual / tts-deckconverter

Generate card decks for Tabletop Simulator.
MIT License
39 stars 5 forks source link

Import from deckstats.net is not correctly pulling the correct card image for the Kaladash Inventions Sets #5

Closed Aznlilly closed 4 years ago

Aznlilly commented 4 years ago

The set is just whatever set it happened to pick as far as I can see.

LoardVader commented 4 years ago

I've been unable to get the program, to pull set specific art from any website, always just the latest art.

jeandeaual commented 4 years ago

@Aznlilly86 Can you tell me which URL or deck file you're trying to import exactly? Is it this one?

@LoardVader If the set is not specified by the deck, the art from the latest set the card was released in will be used. It depends if the website sets the set name or not for each cardwhen exporting a deck. Which website do you have an issue with?

jeandeaual commented 4 years ago

By the way, if you're using the From text tab instead of From URL, you can use this method to pull specific art for a card.

Aznlilly commented 4 years ago

I was using the deckstats.net site, here is an example deck: https://deckstats.net/decks/161156/1740667-fblthp-proteus-scepter-combo

LoardVader commented 4 years ago

i've been using "From URL" on scryfall

jeandeaual commented 4 years ago

@Aznlilly86 @LoardVader Thanks, I see the issue now. It seems that deckstats.net uses some set names (the ones with an underscore, like MPS_KLD for Kaladesh Inventions) that are different from the names used by Scryfall (which expects MPS for Kaladesh Inventions).

I made a manual fix for these set names in 0f675771f351815537b6906e662a6a4e6637b517, which seems to be working:

20200906222809_1

It will be included in the next release, but in the meantime you can test it here (if you're on Windows).

Aznlilly commented 4 years ago

The newly updated version works flawlessly for me so far.

On Sun, Sep 6, 2020 at 9:57 AM Alexis Jeandeau notifications@github.com wrote:

@Aznlilly86 https://github.com/Aznlilly86 @LoardVader https://github.com/LoardVader Thanks, I see the issue now. It seems that deckstats.net uses some set names https://deckstats.net/sets/?lng=en (the ones with an underscore, like MPS_KLD for Kaladesh Inventions) that are different from the names used by Scryfall https://scryfall.com/sets (which expects MPS for Kaladesh Inventions).

I made a manual fix for these set names in 0f67577 https://github.com/jeandeaual/tts-deckconverter/commit/0f675771f351815537b6906e662a6a4e6637b517, which seems to be working:

[image: 20200906222809_1] https://user-images.githubusercontent.com/23304955/92327342-ddc8bb00-f093-11ea-85a7-276f62520331.jpg

It will be included in the next release, but in the meantime you can test it here https://github.com/jeandeaual/tts-deckconverter/suites/1151090358/artifacts/16592224 (if you're on Windows).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jeandeaual/tts-deckconverter/issues/5#issuecomment-687796502, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACSIQESARLKPC6W7EPY7Q53SEOIMDANCNFSM4QPHYLTA .

jeandeaual commented 4 years ago

I released this fix as part of v0.6, so I'm closing the issue. Please feel free to re-open it if it doesn't work for you.