search

jeanguyomarch / eovim

The Enlightened Neovim
https://github.com/jeanguyomarch/eovim/wiki
MIT License
193 stars 3 forks source link

Segfault in a test completion #64

Closed Thanatermesis closed 3 years ago

Thanatermesis commented 3 years ago

Just trying eovim

After to run a dummy file completion (ctrl + x ; ctrl + f ), it segfaulted:

CRI<7420>:eovim /tmp/sources/eovim/src/event/popupmenu.c:48 nvim_event_popupmenu_show() Invalid argument count. (4 >= 5) is false

jeanguyomarch commented 3 years ago

Hello, can you please provide the result of the command eovim --version? I cannot reproduce your issue with my setup, which yields:

Version: 0.2.0

Build Type: Release

Compiled with EFL 1.25.1
Compiled with msgpack 3.3.0
Linked with EFL 1.25.1
Linked with msgpack 3.3.0

Neovim (program: 'nvim') version:

NVIM v0.4.4
Build type: Release
LuaJIT 2.0.5
Compilation: /usr/bin/cc -D_FORTIFY_SOURCE=2 -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -O2 -DNDEBUG -DMIN_LOG_LEVEL=3 -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fno-common -fdiagnostics-color=always -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -I/build/neovim/src/build/config -I/build/neovim/src/neovim-0.4.4/src -I/usr/include -I/build/neovim/src/build/src/nvim/auto -I/build/neovim/src/build/include
Compiled by builduser

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/share/nvim"

Run :checkhealth for more info
Thanatermesis commented 3 years ago 
Version: 0.2.0

Build Type: Release

Compiled with EFL 1.25.99
Compiled with msgpack 3.0.1
Linked with EFL 1.25.99
Linked with msgpack 3.0.1

Neovim (program: 'nvim') version:

NVIM v0.3.4
Build type: Release
LuaJIT 2.1.0-beta3
Compilation: /usr/bin/cc -g -O2 -fdebug-prefix-map=/build/neovim-RiUqEm/neovim-0.3.4=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=1 -DDISABLE_LOG -Wdate-time -D_FORTIFY_SOURCE=1 -Wconversion -O2 -DNDEBUG -DMIN_LOG_LEVEL=3 -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fdiagnostics-color=auto -Wno-array-bounds -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -I/build/neovim-RiUqEm/neovim-0.3.4/build/config -I/build/neovim-RiUqEm/neovim-0.3.4/src -I/usr/include -I/build/neovim-RiUqEm/neovim-0.3.4/build/src/nvim/auto -I/build/neovim-RiUqEm/neovim-0.3.4/build/include
Compiled by team+vim@tracker.debian.org

Features: +acl +iconv -jemalloc +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/share/nvim"

Run :checkhealth for more info
jeanguyomarch commented 3 years ago

Okay, I can reproduce with neovim v0.3.4. I've made a fix in the branch fixes. Please let me know if this solves the problem (or not). If possible, I would advise to use a more recent version of neovim (at least 0.4).

Thanatermesis commented 3 years ago

hum, still having the issue

at the moment I cannot update the version of neovim since it comes from debian buster repos

jeanguyomarch commented 3 years ago

Mh... can you please confirm you used the branch fixes and properly recompiled eovim? This is what I do:

Some explaining :

In my logs, I can see:

DBG<25324>:eovim /src/eovim/src/nvim.c:499 nvim_new() Running "[...]/Downloads/nvim.appimage" --embed
INF<25324>:eovim /src/eovim/src/nvim_attach.c:264 _api_decode_cb() Running Neovim version 0.3.4

If you are really sure that you are using the latest patches of the branch fixes, I would be interested in the logs. Hopefully this isn't an EFL bug...

Thanatermesis commented 3 years ago

Oh, I was building using master

Alright, with the 'fixes' branch it works

Are you going to import the fixes on master? (in order to build the package from the correct & updated branch)

jeanguyomarch commented 3 years ago

Nice, I will push the fix to the master branch.