search

jeanlemotan / esp32-cam-fpv

esp32 cam digital low latency fpv
MIT License
278 stars 68 forks source link

Fix rate adjustment bug and update README.md #28

Closed whstudio123 closed 1 year ago

whstudio123 commented 1 year ago

IDF 5.0 support needs time and our effort together.I have written in README that not support IDF-5.x. This PR foucus on rate adjustment API.

It's not that hard to achieve 200fps in laptop.How about rpi4? I only have less than 40fps.Do you use pi?

lida2003 commented 1 year ago

How about rpi4? I only have less than 40fps.Do you use pi?

No RPI4， I use RPI 3B+ and laptop. So 200fps is achieved on laptop? resolution?? wifi card? os ???

whstudio123 commented 1 year ago

How about rpi4? I only have less than 40fps.Do you use pi?

No RPI4， I use RPI 3B+ and laptop. So 200fps is achieved on laptop? resolution?? wifi card? os ???

No, it's just laptop with empty frames( Air_firmware power off. ) which could achieve over 200 fps.

With the air power on. I'm suffering about very low vfps issue.

So there is no magic now and maybe no one achieves a higher vfps now .I'm really want something happen just like the writter writen in the readme.

whstudio123 commented 1 year ago

I need to mention that the fps is imgui fps, and the vfps is the true fps we wanna.

whstudio123 commented 1 year ago

我们能加一下微信吗，或者留个电话来方便讨论关于esp32-cam-fpv的问题？我觉得打个电话能够更高效的在很短的时间同步我们两个人目前的项目状态。您觉得呢？

---Original--- From: "Daniel @.> Date: Sat, Feb 4, 2023 10:25 AM To: @.>; Cc: @.**@.>; Subject: Re: [jeanlemotan/esp32-cam-fpv] Fix rate adjustment bug and updateREADME.md (PR #28)

How about rpi4? I only have less than 40fps.Do you use pi?

No RPI4， I use RPI 3B+ and laptop. So 200fps is achieved on laptop? resolution?? wifi card? os ???

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

lida2003 commented 1 year ago

我们能加一下微信吗，或者留个电话来方便讨论关于esp32-cam-fpv的问题？我觉得打个电话能够更高效的在很短的时间同步我们两个人目前的项目状态。您觉得呢？

wechat account, see bilibili response.

jeanlemotan commented 1 year ago

Thanks for the PR. Weren't the changes in this PR already merged? Could you rebase?

whstudio123 commented 1 year ago

Go and check https://github.com/jeanlemotan/esp32-cam-fpv/issues/22?notification_referrer_id=NT_kwDOA7NPlLM1Mzk4MDg4NDY2OjYyMDgyOTY0#issuecomment-1413593657

I change the internal api to esp_wifi_config_80211_tx_rate() .

I use IDF-4.4.3.

use internal API: 6ecbe4ef162f317321da02cfe7305db

The result: image

use esp_wifi_config_80211_tx_rate() API: b87d693e607980506719d4ef65c0705

The result: image (Pay attention to the raw data , we could also see the JFIF header which means jpeg.haha~) ATTENTION! Version matters! I checked ESP32 API doc version by version and find that we could officially adjust the rate of 802.11 injection only when using IDF-4.4.2 or newer. IDF-4.4.2 and above says: https://docs.espressif.com/projects/esp-idf/en/v4.4.2/esp32/api-guides/wifi.html#wi-fi-80211-packet-send image

IDF-4.4.1 and below says: https://docs.espressif.com/projects/esp-idf/en/v4.4.1/esp32/api-guides/wifi.html#wi-fi-80211-packet-send 7af13bcf43fc601e6207900c7742ed4

I also find something in ESP-FAQ about the internal api: https://docs.espressif.com/projects/espressif-esp-faq/zh_CN/latest/software-framework/wifi.html f1f7f84a6d44daa8818e925ad5a9866

So, Maybe ESP-FAQ is a little bit of confusing."To set and fix the Wi-Fi sending rate" may only just about "wifi"(we normally heared from) but not 802.11 raw packet. No matter what the ESP-FAQ says,just following the API doc and using the official API to adjust 802.11 rate without a problem. I will make a PR and note we should use at least IDF-4.4.2 version.