search

jeanluc-auge / gpsanapy

gps speed trace analysis for nautic sports
Apache License 2.0
4 stars 2 forks source link

Windr integration phase 1 #8

Closed tgrall closed 2 years ago

tgrall commented 2 years ago

Analyser work & configuration:

jeanluc-auge commented 2 years ago

Great work, thanks! I have tested it with a gpx file (not extensively though) and it looks good. I also reviewed the code, (I'd be interested in github workflow explanations ;) ) and it sounds good. Good to see that the yaml config file was clear enough you could make change to it. However I would not recommend to g=have vmin = 0 for the jibe analysis, I had difficulties and 12knots is kind of the min speed it can support if you want reliable results. Also I will write a windr json method in utils to clean up the dash_server code. PR accepted thanks :)