search

jeanluct / braidlab

Matlab package for analyzing data using braids
GNU General Public License v3.0
23 stars 9 forks source link

loop.plot cannot take multiple loops #133

Open mbudisic opened 8 years ago

mbudisic commented 8 years ago

loop.plot fails when a vector of loops is passed in a way that's not informative to the user. Potential fixes: fail in a more informative way OR generate many axes each containing one row of the argument (not advisable) OR plot all loops on a single axis.

mbudisic commented 8 years ago

Commit 043b71d4c1b8f5eb9012f80e9fdfc4a459b1339b adds a temporary fix: assertion to make the error more transparent.

jeanluct commented 8 years ago

There may be something in the manual about plot now working on multiple loops.

mbudisic commented 8 years ago

Hm, I didn't think to check. In any case, error was ugly and non-informative (something about concatenation of coordinates in the internal getcoords function), so I pre-empted it with an assert.

jeanluct commented 8 years ago

I just mentioned it in case it needed modifying in the guide. It says "Some commands, such as \lstinline{plot}, do not vectorize." This seems fine as it is.

mbudisic commented 7 years ago

Perhaps we should close this as an issue and open a new enhancement instead to have braidlab be able to plot multiple loops - how to do that is a different discussion, I think.

jeanluct commented 7 years ago

We can just reclassify #133 as an enhancement. It would be good to keep this earlier discussion together with the issue.