Closed mbudisic closed 4 years ago
That's a little disturbing. Let me check.
This was fixed in c82bb2c on develop
on 1 August 2018, maybe not merged in master yet?
commit c82bb2c761949e72a177c3caec7ee35198d44e75
Author: Jean-Luc Thiffeault <jeanluc@mailaps.org>
Date: Wed Aug 1 14:17:15 2018 -0500
Misplaced parenthesis.
+braidlab/@braid/private/compact_helper.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This was indeed fixed after the 3.2.3 release: 3.2.3 - 2018-04-04
.
After a long while, I'm compiling
braidlab
on Mac (10.14.6 Mojave, with Apple's Clang v11 compiler), and I get the following warnings oncompact_helper.cpp
.Note in particular parentheses in line 190 - I think this is a clear typo (comparing with above), but just wanted to check. Moving the closing parenthesis of
abs
ahead of==
would result that (-n+1) is correctly matched. Right now, I don't think this is happening.The other warning is a bit more arcane, I am not sure if the compiled code "does the right thing".
There are a bunch of other warnings about deprecations, but I don't think it needs attention asap.
I can fix it, but would like a second opinion.