search

jeanluct / braidlab

Matlab package for analyzing data using braids
GNU General Public License v3.0
24 stars 10 forks source link

Warning label typo? #36

Closed jeanluct closed 9 years ago

jeanluct commented 9 years ago

In some .m files, it appears that error/warning labels have a typo. Running

find . -name *.m | xargs grep BRAIDLAD

in braidlab/ directory reveals them.

This is trivial to fix, namely run

find . -name *.m | xargs sed --in-place 's/BRAIDLAD/BRAIDLAB/g'

in braidlab/ directory, but I'm not sure if this is really a typo, or is there a reason for these labels to be different.

jeanluct commented 9 years ago

From Marko Budisic on 2014-01-22 23:13:32+00:00

If

--in-place

doesn't work, then put

-i=''

instead. (That's two single apostrophes without anything in between)

jeanluct commented 9 years ago

From Jean-Luc Thiffeault on 2014-01-22 23:45:39+00:00

Nope, it's a typo!

jeanluct commented 9 years ago

From Marko Budisic on 2014-01-22 23:47:10+00:00

Fixes Issue #36: warning label typo

→ <<cset 5e9c1a98beb3>>

jeanluct commented 9 years ago

From Jean-Luc Thiffeault on 2014-01-22 23:53:18+00:00

Boy, there were a lot of those! The danger of copy-and-paste...

Thanks!

jeanluct commented 9 years ago

From Marko Budisic on 2014-01-22 23:54:58+00:00

No problem! I copy pasted further, and got confused when I was re-reading my code and saw BRAIDLAD everywhere, but the (convergence) warnings were detected without any problems... I guess two wrongs sometimes do make a right!

jeanluct commented 9 years ago

From Jean-Luc Thiffeault on 2014-01-22 23:56:30+00:00

Would it be simpler to rename the whole package to BRAIDLAD? I like the ring of it! :-)

jeanluct commented 9 years ago

From Marko Budisic on 2014-01-22 23:59:29+00:00

Yes! But that opens door to knockoff names such as BRAIDBLOKE, BRAIDMATE (australian) and even BRAIDGARÇON!