search

jeanluct / braidlab

Matlab package for analyzing data using braids
GNU General Public License v3.0
23 stars 9 forks source link

Should loop have a "boundarypuncture" flag? #72

Closed jeanluct closed 9 years ago

jeanluct commented 9 years ago

When creating the default loop for n punctures with loop(n), an extra boundary puncture is added. Should this be flagged internally? The loop.plot could draw this extra puncture with a different color, thereby alleviating a bit of confusion. And perhaps then the loop dependent property loop.n could then return n-1. Maybe.

jeanluct commented 9 years ago

From Jean-Luc Thiffeault on 2014-10-10 13:36:40+00:00

In 9b0b650, added a 'noboundary' flag. Still doesn't change the internal state, though.

jeanluct commented 9 years ago

From Jean-Luc Thiffeault on 2014-10-10 21:49:50+00:00

Implemented 'nobasepoint' in 45bb3af.

Could forbid generators n-1 when there is a basepoint.

jeanluct commented 9 years ago

From Jean-Luc Thiffeault on 2014-10-16 16:05:35+00:00

Implemented some of this in the branch basepoint-for-loops. It's going ok but I'm not 100% sure this is the right thing.

jeanluct commented 9 years ago

From Jean-Luc Thiffeault on 2014-10-16 16:07:05+00:00

Here's a link to the branch.

jeanluct commented 9 years ago

From Marko Budisic on 2014-10-22 20:53:53+00:00

There's still no internal state that records 'basepoint', correct? It only affects how a loop with integer argument is generated.

Once 'basepoint' becomes an internal state (if ever), loop/vertcat should be updated to make sure loops with different internal states are not stacked. (rev 020bf9b)

jeanluct commented 9 years ago

From Jean-Luc Thiffeault on 2014-10-22 21:08:12+00:00

There is. Try the basepoint-for-loops branch.

jeanluct commented 9 years ago

From Jean-Luc Thiffeault on 2014-10-23 17:43:04+00:00

Merged the branch basepoint-for-loops into default in 23270df, and then closed the branch. Let the problems begin! Once things are stable we can close this issue.