intersec on loop array gives wrong answer

jeanluct / braidlab

Matlab package for analyzing data using braids

GNU General Public License v3.0

23 stars 9 forks source link

intersec on loop array gives wrong answer #74

Closed jeanluct closed 9 years ago

jeanluct commented 9 years ago

This was exposed in d341c71 when writing unit tests.

#!matlab

>> l = loop([1 -1 2 3; 2 3 -1 2]);  &#37; two loops
>> l.intersec

ans =

     3     5     5     3    12     8     2
    -2     2    -3     3     8    10     6

>> l(1).intersec

ans =

     5     7     5     3    12     8     2

>> l(2).intersec

ans =

     3     7     2     8     8    10     6

Oops! The array is clearly wrong, since it gives negative values.

jeanluct commented 9 years ago

From Jean-Luc Thiffeault on 2014-10-10 02:02:53+00:00

Fixed comment about what's wrong in ac5754a.

jeanluct commented 9 years ago

From Jean-Luc Thiffeault on 2014-10-10 02:14:04+00:00

Remember to doublecheck intaxis as well, since it uses similar code.

jeanluct commented 9 years ago

From Jean-Luc Thiffeault on 2014-10-10 02:27:08+00:00

Missing column fixes issue #74.

→ <>