jeannetoh99 / pe

0 stars 0 forks source link

Policy name is case sensitive #11

Open jeannetoh99 opened 3 years ago

jeannetoh99 commented 3 years ago

The following command is accepted:

add n/May p/98765432 e/example@address.com a/123 street pn/Life Time Policy

Screenshot 2020-11-13 at 1.07.12 PM.png

After deleting the previously added client,

The following command is not accepted, as policy name is not found.

add n/May p/98765432 e/example@address.com a/123 street pn/life time policy

Screenshot 2020-11-13 at 1.08.03 PM.png

This can be quite inconvenient. It would be easier to have the policy name case insensitive, or better still, refer to them via an index.

nus-se-bot commented 3 years ago

Team's Response

Policy names are very official Using the right casing is important as they are legal contracts

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The policy names in this case are not used for legal contracts but simply for an insurance agent to keep track, hence I don't think this reason is very valid. Nevertheless, as my alternative recommendation suggests, it would be best to allow the user to refer to the policies by index rather than by name, as this is more optimised for fast users.


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: No reason was given why the severity was lowered, but I believe that the severity is medium as this would be a common problem that affects and inconveniences most if not all users.