search

jeanpan / react-native-camera-roll-picker

📷 A React Native component providing images selection from camera roll
https://www.npmjs.com/package/react-native-camera-roll-picker
MIT License
423 stars 176 forks source link

Advanced ListView performance. #21

Closed BROUDING closed 8 years ago

BROUDING commented 8 years ago

Hi jeanpan,

I tested your awesome project and found out sometimes on iOS, if I scroll down a lot (like 1200 pictures), the ListView gets pretty slow or die sometimes.

And I found on ReactNative doc >> https://facebook.github.io/react-native/docs/performance.html#scrollrenderaheaddistance

that, there are some essential props to be modified by user.

Check this issue for the better world ::D

Thanks, John

jeanpan commented 8 years ago

@BROUDING COOL ! Thanks for the PR, I will merge it after testing.

BROUDING commented 8 years ago

@jeanpan

That'll be awesome ! But the thing is, there're no recommendation for the values of the props on web (as far as I found). I set default values by my experiments, but you could test them and recommend better values ::D

( I used to develop Android apps and I'm pretty new for React Native... :P )

Have a good day !

jeanpan commented 8 years ago

@BROUDING It looks good. Ship it. Thanks !