search

jeanpan / react-native-camera-roll-picker

📷 A React Native component providing images selection from camera roll
https://www.npmjs.com/package/react-native-camera-roll-picker
MIT License
422 stars 176 forks source link

return size of selected images, fix jeanpan/react-native-camera-roll-… #9

Closed sibelius closed 8 years ago

sibelius commented 8 years ago

…picker#8

st0ffern commented 8 years ago

please note that this is a breaking change

cc @jeanpan @sibelius

sibelius commented 8 years ago

it is! please bump a major version after merge this PR and this one https://github.com/jeanpan/react-native-camera-roll-picker/pull/7

jeanpan commented 8 years ago

@sibelius the PR #7 has been merged. Could you help to fix the conflict.

st0ffern commented 8 years ago

https://github.com/jeanpan/react-native-camera-roll-picker/blob/master/index.js#L91

onPress={event => this._selectImage(item.node.image.uri)}>

to

onPress={event => this._selectImage(item.node.image)}>

https://github.com/jeanpan/react-native-camera-roll-picker/blob/master/index.js#L96

{ (this.state.selected.indexOf(item.node.image.uri) >= 0)? selectedMarker : null }

to

{ (this.state.selected.indexOf(item.node.image) >= 0)? selectedMarker : null }

cc @jeanpan @sibelius

_Please note that this is a breaking change_

sibelius commented 8 years ago

closing in favor of this one https://github.com/jeanpan/react-native-camera-roll-picker/pull/10