search

jeanparpaillon / erlang-dbus

Erlang DBUS implementation (forked from unmaintained erlang-dbus)
Apache License 2.0
52 stars 22 forks source link

Remove procket and use unix domain socket in erlang 19.0-rc2 #23

Closed saa closed 8 years ago

jeanparpaillon commented 8 years ago

Thanks for your pr. Build fails on a warning: src/dbus_transport_unix.erl:52: variable 'Mode' is unused

saa commented 8 years ago

Hm, I will fix today.

saa commented 8 years ago

Compile is ok, but tests failed also as for me. Interesting.

saa commented 8 years ago

@jeanparpaillon can you run tests on this branch on your env?

jeanparpaillon commented 8 years ago

The pr fails because of erlang 19 not available on travis Can you add a script to test the pr with erlang 19 on travis ? Using kerl would probable be the best choice

slashmili commented 8 years ago

Well I'm not sure why do you say Travis doesn't support Erlang 19 because essentially it uses kerl. and as you can see in this build that I just ran https://travis-ci.org/slashmili/erlang-dbus/builds/161296209 (from my own fork) it's using Erlang 19:

...
$ erl -eval 'erlang:display(erlang:system_info(otp_release)), halt().'  -noshell
"19"
...

I also tried it in my machine with Erlang 19.0.2 and it failed.

jeanparpaillon commented 8 years ago

Last time I've checked, erlang 19 was not supported on this page: https://docs.travis-ci.com/user/languages/erlang It may have changed, hopefully :) Anyway, there may be other issues on this pull request. Feel free to contribute, (re)code ...