search

jeanphix / Ghost.py

Webkit based scriptable web browser for python.
http://ghost-py.readthedocs.org/en/latest/
2.77k stars 380 forks source link

Remove xvfb support #75

Open kanzure opened 11 years ago

kanzure commented 11 years ago

It would be nice to not have to use xvfb. I think phantomjs achieved headlessness by using QPA in QT to no longer require X11. A temporary alternative to xvfb is to use xserver-xorg-video-dummy, but that's not really the same as becoming more headless...

Here's how phantomjs seems to have done it:

zcattacz commented 11 years ago

http://www.riverbankcomputing.com/pipermail/pyqt/2012-July/031696.html looks not optimistic. Unless someone can roll out QPA enabled PyQt.

asdil12 commented 11 years ago

What about pyside? Am 24.03.2013 05:40 schrieb "zcattacz" notifications@github.com:

http://www.riverbankcomputing.com/pipermail/pyqt/2012-July/031696.html looks not optimistic. Unless someone can roll out QPA enabled PyQt.

— Reply to this email directly or view it on GitHubhttps://github.com/jeanphix/Ghost.py/issues/75#issuecomment-15351411 .

caioariede commented 11 years ago

:+1: for removing the Xvfb dependency on OSX

andreycizov commented 10 years ago

The original code, in the case of Xvfb missing, tries to run it as "Xvfb :99", which is a security issue, at least on latest Ubuntu, where the default running parameters are listening on all network interfaces.

Behaviour like that should be properly error'd (or at least giving an error message), given the fact that one might have just forgotten to properly set up Xvfb, and the application would still be able to run.

I would have made a pull request myself, but given the fact that this might already be considered a default behaviour, decided that it's better to just note this here.