search

jeanregisser / react-native-slider

A pure JavaScript <Slider> component for react-native
MIT License
1.3k stars 571 forks source link

Is this repo in active development? #135

Open finalquest opened 6 years ago

finalquest commented 6 years ago

Hi. First off all. Awesome repo. I should ask. Is this repo under active development?. I need to know if should I fork, or summit a pullrequest.

Regards

ymahnovskyy commented 5 years ago

Yeah, or maybe someone is supporting this library in some fork? There are a lot of interesting pull requests is there some fork which try to merge at least some pull requests?

karltaylor commented 5 years ago

Seems abandoned, @jeanregisser are you still actively developing? Would you consider contributors?

TrillCyborg commented 5 years ago

If you want the RTL fixes from the latest release I have published to NPM since @jeanregisser seems to have forgotten to...

@jeanregisser please publish when you can!

https://www.npmjs.com/package/trill-react-native-slider

miblanchard commented 5 years ago

I have forked and published a new version that has been updated. I intend to maintain this and add new features over time - https://www.npmjs.com/package/@miblanchard/react-native-slider

For now I have added multiple thumbs, clicking/tapping, and custom component thumbs. I am interested in adding a custom component above the thumb while it is moving (think a video thumbnail for a scrubber), and would like to try using react-native-gesture-handler and reanimated for improved performance.

Please feel free to submit PRs for any of the above!!

flyskywhy commented 4 years ago

@miblanchard , I have added react-native-gesture-handler in my forked https://github.com/flyskywhy/react-native-smooth-slider , and it works well in https://github.com/flyskywhy/react-native-slider-color-picker .

Maybe you can ref to the commit which just added react-native-gesture-handler : https://github.com/flyskywhy/react-native-smooth-slider/commit/59fa00f506185cebdbdc11337976d2ec775eebb5

miblanchard commented 4 years ago

@miblanchard , I have added react-native-gesture-handler in my forked https://github.com/flyskywhy/react-native-smooth-slider , and it works well in https://github.com/flyskywhy/react-native-slider-color-picker .

Maybe you can ref to the commit which just added react-native-gesture-handler :

https://github.com/flyskywhy/react-native-smooth-slider/commit/59fa00f506185cebdbdc11337976d2ec775eebb5

Thanks for sharing! I'll take a look. I think I'm going to try and add gesture handler as an optional dependency and maintain backwards compatiblity.

This will definitely be a good reference. Thanks @flyskywhy