jeanregisser / react-native-slider

A pure JavaScript <Slider> component for react-native
MIT License
1.3k stars 571 forks source link

Fix a warnning for useNativeDriver #198

Open shixiaoquan opened 2 years ago

shixiaoquan commented 2 years ago

Hi! πŸ‘‹

Firstly, thanks for your work on this project! πŸ™‚

Today I used patch-package to patch react-native-slider@0.11.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-slider/lib/Slider.js b/node_modules/react-native-slider/lib/Slider.js
index c640410..fad8f26 100644
--- a/node_modules/react-native-slider/lib/Slider.js
+++ b/node_modules/react-native-slider/lib/Slider.js
@@ -420,7 +420,7 @@ _this.props.animationConfig,
 {toValue:value});

-_reactNative.Animated[animationType](_this.state.value,animationConfig).start();},_this.
+_reactNative.Animated[animationType](_this.state.value,{...animationConfig, useNativeDriver: false}).start();},_this.

 _fireChangeEvent=function(event){
diff --git a/node_modules/react-native-slider/src/Slider.js b/node_modules/react-native-slider/src/Slider.js
index 37deee5..dd48dc5 100644
--- a/node_modules/react-native-slider/src/Slider.js
+++ b/node_modules/react-native-slider/src/Slider.js
@@ -420,7 +420,7 @@ export default class Slider extends PureComponent {
       {toValue : value}
     );

-    Animated[animationType](this.state.value, animationConfig).start();
+    Animated[animationType](this.state.value, {...animationConfig, useNativeDriver: true}).start();
   };

   _fireChangeEvent = (event) => {

This issue body was partially generated by patch-package.