jeanregisser / react-native-slider

A pure JavaScript <Slider> component for react-native
MIT License
1.3k stars 571 forks source link

Error when used with latest rn, ViewPropTypes has be deprecated #206

Open shrynshjn opened 2 years ago

shrynshjn commented 2 years ago

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-slider@0.11.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-slider/lib/Slider.js b/node_modules/react-native-slider/lib/Slider.js
index c640410..aae12fc 100644
--- a/node_modules/react-native-slider/lib/Slider.js
+++ b/node_modules/react-native-slider/lib/Slider.js
@@ -5,6 +5,7 @@ var _react=require("react");var _react2=_interopRequireDefault(_react);

 var _reactNative=require("react-native");
+var _reactNativePropTypes=require("deprecated-react-native-prop-types");

@@ -548,14 +549,6 @@ return false;}}]);return Slider;}(_react.PureComponent);Slider.propTypes={ /**
      * Callback called when the user finishes changing the value (e.g. when
      * the slider is released).
      */onSlidingComplete:_propTypes2.default.func, /**
-     * The style applied to the slider container.
-     */style:_reactNative.ViewPropTypes.style, /**
-     * The style applied to the track.
-     */trackStyle:_reactNative.ViewPropTypes.style, /**
-     * The style applied to the thumb.
-     */thumbStyle:_reactNative.ViewPropTypes.style, /**
-     * Sets an image for the thumb.
-     */thumbImage:_reactNative.Image.propTypes.source, /**
      * Set this to true to visually see the thumb touch rect in green.
      */debugTouchArea:_propTypes2.default.bool, /**
      * Set to true to animate values with default 'timing' animation type
diff --git a/node_modules/react-native-slider/src/Slider.js b/node_modules/react-native-slider/src/Slider.js
index 37deee5..45e6506 100644
--- a/node_modules/react-native-slider/src/Slider.js
+++ b/node_modules/react-native-slider/src/Slider.js
@@ -11,8 +11,8 @@ import {
   PanResponder,
   View,
   Easing,
-  ViewPropTypes
 } from "react-native";
+import { ViewPropTypes, ImagePropTypes } from "deprecated-react-native-prop-types";

 import PropTypes from 'prop-types';

@@ -146,7 +146,7 @@ export default class Slider extends PureComponent {
     /**
      * Sets an image for the thumb.
      */
-    thumbImage: Image.propTypes.source,
+    thumbImage: ImagePropTypes.source,

     /**
      * Set this to true to visually see the thumb touch rect in green.

This issue body was partially generated by patch-package.

sayancitytech commented 8 months ago

I have added import { ViewPropTypes } from 'deprecated-react-native-prop-types'; in Slider.js then yarn patch-package react-native-slider