search

jeanregisser / react-native-slider

A pure JavaScript <Slider> component for react-native
MIT License
1.3k stars 574 forks source link

Custom thumb view. #47

Open vaukalak opened 8 years ago

vaukalak commented 8 years ago

Hey, and great project!

It would be nice to have a possibility, to setup a custom thumb View, for example a view wrapped in a tooltip https://github.com/chirag04/react-native-tooltip .

vaukalak commented 8 years ago

Implemented in https://github.com/jeanregisser/react-native-slider/pull/48

lewisbarber commented 8 years ago

This is just what I'm looking for in an app I'm building. Any chance of getting this merged soon?? Thanks!

vaukalak commented 8 years ago

@lewisbarber you can ref my GH as dependency for now "react-native-slider": "git+https://github.com/vaukalak/react-native-slider.git#f9fd0b07d69f8cac77c8193038fb9a012dd7866e",

Nicomalacho commented 7 years ago

Any advance on this new feature ?

vaukalak commented 7 years ago

@Nicomalacho last PR was closed on Jun 13. So probably author is not available at the moment.

GregTheGreek commented 6 years ago

I'm assuming this feature is not being implemented? has anyone found something that works? I would consider making a PR?

vaukalak commented 6 years ago

@GregTheGreek yeah, sorry for that, will fix my PR near to the and of this week.

vaukalak commented 6 years ago

@GregTheGreek Added new PR, which actually fixes some migrations to rect 16: https://github.com/jeanregisser/react-native-slider/pull/88 , asa this will be merged, will update my PR.