search

jeanslack / FFcuesplitter

FFmpeg based audio splitter for CDDA images associated with .cue files
GNU General Public License v3.0
52 stars 6 forks source link

Add option to encode to Opus #27

Closed tsweet64 closed 1 year ago

tsweet64 commented 1 year ago

This adds the option to encode to Ogg Opus, my preferred codec.

My vim was setup to automatically remove trailing whitespaces from lines, leading to a few unrelated lines to be changed in the edited files. If this is a problem, I can change them back.

Thank you so much for this project! I've found it to be very useful. So much better than shnsplit...

jeanslack commented 1 year ago

This adds the option to encode to Ogg Opus, my preferred codec.

My vim was setup to automatically remove trailing whitespaces from lines, leading to a few unrelated lines to be changed in the edited files. If this is a problem, I can change them back.

Thank you so much for this project! I've found it to be very useful. So much better than shnsplit...

Thanks, I really appreciate your PR and will merge it, but to be fully accepted it should pass flake8 linter check (see CI below) looks for ./ffcuesplitter/cuesplitter.py:98:80: E501 line too long (85 > 79 characters). Also trailing and leading spaces in the README.md file (like all *.md files) are part of the Markdown programming language syntax. Please format that text accordingly.

Thanks for your appreciations! I wait for your changes, then I merge.

tsweet64 commented 1 year ago

Thanks. I added a new commit to revert the changes to whitespace and fix the length of ./ffcuesplitter/cuesplitter.py:98. Let me know if anything else is needed