search

jeanslack / Videomass

Videomass is a free, open source and cross-platform GUI for FFmpeg and yt-dlp
https://jeanslack.github.io/Videomass/
GNU General Public License v3.0
1.06k stars 49 forks source link

Input file name containing single quote (') are not accepted #224

Closed chrisadas closed 1 year ago

chrisadas commented 1 year ago

What operating system are you using?
Windows 10 22H2

What version of Videomass are you using and how did you install or run it?
v5.0.0_x86_64 portable

Describe the bug
When adding input files by dragging them into the GUI window, any files containing single quote (') are not added. This happened both with the single quote being in the file name or directory name.

jeanslack commented 1 year ago

Hello @chrisadas

It's not exactly a bug, although it looks like it. This is an expected behavior of this application, and was requested because some operations like file concatenation are really problematic with pathnames having single or double quotes.

Also, a warning message should appear in the status bar when importing quoted pathnames. Do you confirm this?

chrisadas commented 1 year ago

Hi @jeanslack I see. Yes, the status bar does show "file has illegal characters like: ", which I did not noticed before.

I don't know if it has much value for others, but additional information here like number of files that are rejected or list of them would be cool.

jeanslack commented 1 year ago

You are right, your proposal is good and I think I will implement it soon, thanks!