Make some colors customizable in theme

jeanverster / chakra-ui-steps

Steps component designed to work seamlessly with Chakra UI

https://chakra-ui-steps.vercel.app

390 stars 44 forks source link

Make some colors customizable in theme #32

Closed mjnaderi closed 3 years ago

mjnaderi commented 3 years ago

I want to display steps on a gray.700 background. But some colors in this package are hard-coded to gray.700 (connector, icon container background) and they are not visible in a box with gray.700 background:

This PR moves some styles from component code to theme, so developers can override default values.

mjnaderi commented 3 years ago

@jeanverster My first effort didn't pass tests. I fixed it and squashed the commits.

jeanverster commented 3 years ago

Hey @mjnaderi, thank you for this! I had been meaning to address this but haven't got around to it yet.. PR looks good 👌🏼 I will merge this now and then try get a release out later today..

jeanverster commented 3 years ago

Released in v1.5.0