jeanyang04 / pe

0 stars 0 forks source link

Accidental typo after -l will be counted as part of address. #11

Open jeanyang04 opened 1 week ago

jeanyang04 commented 1 week ago

Summary

Command like :a -n John -l Clementi Ave -rRemark will cause remarks to be in address because of typo.


Screenshots

image.png


Reasoning for Severity

This is a common typo and may cause occasional inconvenience for users to edit again. Perhaps a more detailed check can be carried out between prefixes to prevent such cases.

nus-pe-script commented 1 week ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Wrong error message

Command: :a -n england -p91231321

Screenshot 2024-11-15 at 5.22.11 PM.png

As seen in the screenshot, the field that is wrong is my phone number as I need an extra space between the prefix and the phone number. However, the error message is directing me to change the name when it is clearly not blank. This is very misleading and will potentially confuse users, making the app slightly difficult to use.


[original: nus-cs2103-AY2425S1/pe-interim#1343] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Hello, thanks for testing our product! This issue arises because "england -p1231321" together is viewed as the name parameter. Although we understand this rare case could cause confusion to users, we believe that this is a lower priority issue than the work already done in v1.6. Identifying this type of error would require a lot more parsing (e.g. checking the beginning of each word for command flags) and thus require a lot more effort the the current implementation.

In addition, the software does still fail gracefully, even if the error message may not be that specific.

Hope that clarifies your queries, thanks for pointing that out!

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]