As the title says, this PR will split the variable that controls the atlas dimension and the variable that toggles whether PBR is enabled or not into different files. This is a future-proofing measure to ensure that if Mojang tweaks the atlas size, the end users won't need to manually tweak the other.glsl file with updated values for older PBR texture packs, as currently, the PBR toggle must also include the atlas dimensions alongside it.
I am aware that this change will break existing PBR packs, but the benefit here definitely seems worth it, and it's an incredibly simple fix if just removing the old other.glsl file and replacing it with the new pbr.glsl file in the same place
Summary:
As the title says, this PR will split the variable that controls the atlas dimension and the variable that toggles whether PBR is enabled or not into different files. This is a future-proofing measure to ensure that if Mojang tweaks the atlas size, the end users won't need to manually tweak the
other.glslfile with updated values for older PBR texture packs, as currently, the PBR toggle must also include the atlas dimensions alongside it.I am aware that this change will break existing PBR packs, but the benefit here definitely seems worth it, and it's an incredibly simple fix if just removing the old
other.glslfile and replacing it with the newpbr.glslfile in the same place