jebbyk / OSBES-minecraft-bedrock-edition-shader

shaders for minecraft_pe that uses the latest functionality of OpenGLES 3.0
GNU General Public License v3.0
145 stars 50 forks source link

Waving Blocks Bug - OSBES should improve accurateness of waving grass target detection to prevent unnecessary waving blocks #252

Open JavesBastatas opened 2 years ago

JavesBastatas commented 2 years ago

With OSBES v0.14.0, here are some list of blocks thats behaves identically with waving grass, seems to wave entirely/partially:

• Doors • Trapdoors • Iron bars • Powder Snow • Anvil • Composter • Scaffolding • Hopper • Sea Pickle • Brewing Stand • Stone Cutter • Flower Pot

Expected Behavior

The listed blocks shouldn't be affected by waving grass behaviour unless intended.

Current Behavior

The textures "wave" like a waving grass/leaves. It can be seen in different angles.

Steps to Reproduce

Try to place the blocks listed. Observe for at least 5 seconds where the grass/leaves starts moving/waving. There you can see the bug.

If you can't, try to move in different angles.

Edit: Minecraft version: 1.18

hope3x commented 2 years ago

I think we'd appreciate it if you could send an example.

JavesBastatas commented 2 years ago

Clear Weather:

https://user-images.githubusercontent.com/71550133/147996880-f79b000f-c451-4a39-bb6a-642c35f62bba.mp4

When raining (oops, they look like worms):

https://user-images.githubusercontent.com/71550133/147996965-ae74e053-7c64-4f83-adfd-2775ad0930c6.mp4